asserts: implement Database.FindSequence #8907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
based on #8906 |
FindSequence finds a sequence-forming assertion based the given headers. Provided headers must contain a prefix of the primary key for the assertion type except for the sequence header. Th assertion is the first in the sequence under the prefix with sequential number > after. If after is -1 it returns instead the assertion with the largest sequential number.
pedronis
force-pushed
the
asserts-find-sequence
branch
from
d8c2c51
to
237c010
Compare
stolowski
reviewed
Jul 2, 2020
| return nil, err | ||
| } | ||
| if !assertType.SequenceForming() { | ||
| return nil, fmt.Errorf("cannot use FindSequence with not sequence-forming assertion type %q", assertType.Name) |
stolowski
approved these changes
Jul 7, 2020
bboozzoo
approved these changes
Jul 7, 2020
| } | ||
| } | ||
|
|
||
| seqKey, err := keysFromHeaders(assertType.PrimaryKey[:len(assertType.PrimaryKey)-1], sequenceHeaders) |
There was a problem hiding this comment.
// all keys but the last one which is the sequence number
|
@bboozzoo @stolowski I'll land this and address the two small points in a follow up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FindSequence finds a sequence-forming assertion based the given
headers. Provided headers must contain a prefix of the primary key
for the assertion type except for the sequence header.
Th assertion is the first in the sequence under the prefix with
sequential number > after.
If after is -1 it returns instead the assertion with the largest
sequential number.