This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Simplify run-checks by offloading dependency installation to a travis-specific sript #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,26 +12,10 @@ STATIC_GO="" | |||
| STATIC_JS="" | |||
| UNIT_GO="" | |||
| UNIT_JS="" | |||
| SKIP_NPM_INSTALL="no" | |||
| export PHANTOMJS_BIN=`pwd`/node_modules/.bin/phantomjs | |||
There was a problem hiding this comment.
you might want to use BASH_SOURCE here instead of pwd?
There was a problem hiding this comment.
no sure I understand what you said below, ... I was not talking about $0 there (on the contrary) ... and pwd is very context specific
|
hmm, actually no : this is bash specific and $0 is not considered super
reliable if the caller fiddles with it
…On Thu, Feb 16, 2017 at 5:17 PM, Alexandre Abreu ***@***.***> wrote:
***@***.**** commented on this pull request.
one small comment
------------------------------
In run-checks
<#160 (comment)>:
> @@ -12,26 +12,10 @@ STATIC_GO=""
STATIC_JS=""
UNIT_GO=""
UNIT_JS=""
-SKIP_NPM_INSTALL="no"
+export PHANTOMJS_BIN=`pwd`/node_modules/.bin/phantomjs
you might want to use BASH_SOURCE here instead of pwd?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#160 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADyp4vAMJFo9-6z4IvFh3BkoVdIyDY_jks5rdHaegaJpZM4MC1Bq>
.
|
|
ok LGTM :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.