This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Use SearchField from snapweb-toolkit. #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justincan
force-pushed
the
snapweb-toolkit-1
branch
from
0e53768
to
be63274
Compare
|
Looks ok except that the selenium test dont work anymore with this & the resulting classname changes |
justincan
force-pushed
the
snapweb-toolkit-1
branch
from
8ff20ec
to
ce3d592
Compare
|
Tests fixed. It does raise an issue; it may be a little fragile to sniff out items all the time, ids should probably be put in place, purely for testing purposes. |
|
+1 for adding test IDs
…On Tue, Apr 4, 2017 at 9:03 AM, Justin McPherson ***@***.***> wrote:
Tests fixed.
It does raise an issue; it may be a little fragile to sniff out items all
the time, ids should probably be put in place, purely for testing purposes.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#204 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADyp4sJY1NY3TiUb5wQCPrcJOHkxoqOJks5rsetcgaJpZM4MewpI>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for acceptance of the SearchField component to snapweb-toolkit.
See canonical-web-and-design/snapweb-toolkit#3
Not to be committed until accepted.
Note: styles were left - not all search using screens are reactified.