Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

Re-enable power management support. #216

Merged
merged 1 commit into from
Apr 11, 2017

Conversation

justincan
Copy link
Contributor

Using shutdown interface on snapd.

@dbarth
Copy link

dbarth commented Mar 29, 2017

Works fine and the code is clean.

What would be great though is a spread test to verify that a VM actually shuts down or reboots. Test VMs can either run a classic 16.04 or an all-snap OS. I think this could be doable by looking into tests lie https://github.com/snapcore/snapd/blob/master/tests/main/ubuntu-core-reboot/task.yaml or https://github.com/snapcore/spread/tree/master/tests/reboot

@AlexandreAbreu
Copy link
Contributor

I think that we should also add a bug somewhere so that Jamie can make snapweb autoconnect to shutdown right?

Using shutdown interface on snapd.
@justincan
Copy link
Contributor Author

@AlexandreAbreu Do you know where that is, or is a request on the store?

@dbarth
Copy link

dbarth commented Apr 11, 2017

Ok, i filled https://bugs.launchpad.net/snapweb/+bug/1681693 to track the request to auto-connect the 'shutdown' interface.

@dbarth
Copy link

dbarth commented Apr 11, 2017

For reference, @justincan is proposing to enhance reboot/shutdown support in the spread test system, to implement a more realistic integration test.

@dbarth
Copy link

dbarth commented Apr 11, 2017

Not blocking on tests further. I re-tested the code and will now merge that in.

@dbarth dbarth merged commit 9654ab2 into snapcore:master Apr 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants