Skip to content

Commit

Permalink
Bump base version of go to 1.13
Browse files Browse the repository at this point in the history
There are two main reasons:

Go 1.10 fails to `go get` dependencies of spread as they have introduced build
flags unrecognized by 1.10, which causes spurious duplicate symbol errors. An
example can be seen on the test logs from
#111

    The command "eval go get -v -t ./... " failed.
    # golang.org/x/term
    ../../../golang.org/x/term/term_unix_linux.go:9:26: ioctlReadTermios redeclared in this block
	previous declaration at ../../../golang.org/x/term/term_unix_aix.go:9:26
    ../../../golang.org/x/term/term_unix_linux.go:10:27: ioctlWriteTermios redeclared in this block
	previous declaration at ../../../golang.org/x/term/term_unix_aix.go:10:2

This makes CI broken, this was not noticed simply because of low rate of
activity on the project.

The second reason is to get improved `go vet`, as certain issues have gone
unnoticed simply because the tooling was older.

I chose to bump the base version to Go 1.13 as it is used in Ubuntu 20.04 and
represents a reasonable upgrade.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@huawei.com>
  • Loading branch information
Zygmunt Krynicki committed Jan 12, 2021
1 parent 0e3ac77 commit 695d5ec
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
language: go
go:
- "1.10"
- "1.13"

env:
global:
Expand Down

0 comments on commit 695d5ec

Please sign in to comment.