runner: reduce for+select to for range in runner.Loop #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@huawei.com>
mvo5
approved these changes
Jul 27, 2021
mvo5
reviewed
Feb 4, 2022
| } | ||
| debugf("Worker terminated.") | ||
| return nil |
There was a problem hiding this comment.
Hm, looks like this is not ready. Current go complains:
./runner.go:246:1: missing return at end of function
we could of course just move the reutrn down but i would feel better I think if we had a a unit test here, given the function I'm not sure that is easy to do though :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@huawei.com