Fix Fedora images in LXD backend #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saviq
reviewed
Mar 9, 2018
|
|
||
| if s.Distro() == Fedora { | ||
| // Fedora LXD images do *not* contain tar by default, so we must install it manually | ||
| args = []string{"exec", s.d.Name, "--", "dnf", "install", "--assumeyes", "tar"} |
There was a problem hiding this comment.
As discussed, this could be done by adding tar to the fedora image setup script instead.
Saviq
reviewed
Mar 9, 2018
| @@ -156,6 +221,17 @@ func isDebArch(s string) bool { | |||
| return false | |||
| } | |||
|
|
|||
| func sshInstallCommand(distro Distro) []string { | |||
| if distro == Ubuntu || distro == Debian { | |||
| return []string{"apt", "install", "openssh-server"} | |||
There was a problem hiding this comment.
This seems to be fixing Ubuntu and Debian, not Fedora, as the PR title suggests, but having spoken to people behind linux-containers.org, ssh servers are not, and won't be, installed in those images on purpose, for security reasons (default ssh server settings are often too open).
RAOF
changed the title
This was referenced Sep 8, 2019
RAOF
force-pushed
the
master
branch
5 times, most recently
from
5d25cfa
to
ea89126
Compare
Snaps can't access binaries outside their shipped rootfs, so ship the lxc command in the snap. This requires that the user manually connect the lxd interface, but that's unavoidable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42, Fixes #44