New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fedora images in LXD backend (Fixes #42, Fixes #44) #48

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@RAOF
Copy link

RAOF commented Jan 4, 2018

No description provided.


if s.Distro() == Fedora {
// Fedora LXD images do *not* contain tar by default, so we must install it manually
args = []string{"exec", s.d.Name, "--", "dnf", "install", "--assumeyes", "tar"}

This comment has been minimized.

@Saviq

Saviq Mar 9, 2018

Contributor

As discussed, this could be done by adding tar to the fedora image setup script instead.

@@ -156,6 +221,17 @@ func isDebArch(s string) bool {
return false
}

func sshInstallCommand(distro Distro) []string {
if distro == Ubuntu || distro == Debian {
return []string{"apt", "install", "openssh-server"}

This comment has been minimized.

@Saviq

Saviq Mar 9, 2018

Contributor

This seems to be fixing Ubuntu and Debian, not Fedora, as the PR title suggests, but having spoken to people behind linux-containers.org, ssh servers are not, and won't be, installed in those images on purpose, for security reasons (default ssh server settings are often too open).

@niemeyer

@RAOF RAOF force-pushed the RAOF:master branch from 7abf156 to 326f35c Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment