Add additional content #15
Conversation
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
brlin-tw
force-pushed
the
patch-additional-content
branch
from
5af15cf
to
a1d8d94
Compare
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
This patch introduces the /snap/patches directory for packagers to place patches used in the packaging process. A `patches` part is included to install these files under $SNAPCRAFT_STAGE/packages to be used by other parts. A Sed script is also included to patch the desktop entries' name and icon. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
For adding screenshots. Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
brlin-tw
force-pushed
the
patch-additional-content
branch
from
a1d8d94
to
38e06a5
Compare
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
| @@ -15,12 +15,12 @@ distributions.</p> | |||
|
|
|||
| ## Install | |||
|
|
|||
| sudo snap install my-snap-name | |||
| sudo snap install --channel=edge --devmode my-snap-name | |||
There was a problem hiding this comment.
I think we want this to remain as-is.
There was a problem hiding this comment.
I agee. Please revert this change @Lin-Buo-Ren
|
|
||
| ([Don't have snapd installed?](https://snapcraft.io/docs/core/install)) | ||
|
|
||
| <!-- Uncomment and modify this when you have a screenshot | ||
|  | ||
|  |
There was a problem hiding this comment.
Files in /snap/ will be copied into the package. They cannot be filtered via stage: or prime: keywords. 👎 on this one.
There was a problem hiding this comment.
I agree. Please revert this change @Lin-Buo-Ren
| @@ -0,0 +1,3 @@ | |||
| # /snap/patches | |||
There was a problem hiding this comment.
Files in /snap/ will be copied into the package. They cannot be filtered via stage: or prime: keywords. 👎 on this one.
There was a problem hiding this comment.
I agree. Please revert this change @Lin-Buo-Ren
| ## with localestring format to let the translators fill in | ||
| ## additional localized string and use these values to replace | ||
| ## the Name keys here. | ||
| s/^\(Name\(\[.\+\]\)\?=.*\)$/\1 (Snappy Edition)/g |
There was a problem hiding this comment.
I don't like calling out that an application in a snap is any different to the same application packaged elsewhere. This is an example that people will use in their packages if we include it in this repo. I therefore think this line should be dropped.
There was a problem hiding this comment.
I agree. Also Snappy is not how we refer to Snapcraft or Snaps these days. @Lin-Buo-Ren please revert this change.
| # DISABLED: Bug #1775582 “`organize:{ /: another-dir/ }` causes the items under host root directory to be copied in another-dir” : Bugs : Snapcraft | ||
| # https://forum.snapcraft.io/t/organize-another-dir-causes-the-items-under-host-root-directory-to-be-copied-in-another-dir/5806 | ||
| #organize: | ||
| #/: patches/ |
There was a problem hiding this comment.
please drop the commented-out block
There was a problem hiding this comment.
I agree, please remove this @Lin-Buo-Ren. I don't think we should be adding boilerplate that is only required for a few cases.
| "$SNAPCRAFT_PART_INSTALL"/*.patch \ | ||
| "$SNAPCRAFT_PART_INSTALL"/*.sed \ | ||
| "$SNAPCRAFT_PART_INSTALL"/patches \ | ||
| || true # Empty patches folder is allowed |
There was a problem hiding this comment.
this override script isn't needed, please drop.
There was a problem hiding this comment.
I really don't think we should be complicating a template yaml with patches. They are only required in rare cases.
| || true # Empty patches folder is allowed | ||
| stage: | ||
| - patches/* | ||
| override-prime: 'true' |
There was a problem hiding this comment.
I'd like to see this patches stuff removed from the template yaml entirely. However, @Lin-Buo-Ren you have come up with an interesting use case. Perhaps a blog post on snapcraft.io about best practice for applying patches, when required, to a snap would be a good idea? What to collaborate on that?
| "$SNAPCRAFT_PART_INSTALL"/patches \ | ||
| || true # Empty patches folder is allowed | ||
| stage: | ||
| - patches/* |
|
Thanks for the review, I'll find some time to drop the undesirable content. |
|
@Lin-Buo-Ren are you still working on this? I'll close it for the time being. Feel free to reopen it when you find time to work on it again! |
This patch adds additional content to the template for convenience.