Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync version should add quotes around number #20

Closed
merlijn-sebrechts opened this issue Dec 6, 2023 · 1 comment
Closed

Sync version should add quotes around number #20

merlijn-sebrechts opened this issue Dec 6, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@merlijn-sebrechts
Copy link
Member

What changes would you like?

The sync version script removes the quotes around the version. This breaks the build: https://github.com/snapcrafters/sublime-merge/actions/runs/7118311514/job/19380974821

Any extra information?

No response
@merlijn-sebrechts merlijn-sebrechts added the enhancement New feature or request label Dec 6, 2023
@merlijn-sebrechts
Copy link
Member Author

fixed!

It completely stumped me why this didn't work here, but did on signal-desktop.

Apparently signal-desktop's version number is still recognized as a string even without quotes, because it has two dots instead of one or zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@merlijn-sebrechts