Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exports to work with cabal HEAD #146

Closed
wants to merge 1 commit into from

Conversation

hasufell
Copy link

@Mikolaj
Copy link

Mikolaj commented Mar 27, 2022

Great job. I'm not sure what severity of warnings we are going to issue in 3.8 for such imperative conditionals as in the original, but certainly it's going to be frowned upon. :)

@Mikolaj
Copy link

Mikolaj commented Mar 27, 2022

BTW, the PR just landed: haskell/cabal#7966, so now it would be an excusable warning. After your fix, the warning is, I hope, gone.

@mightybyte
Copy link
Member

Let's wait until these changes land in an officially released cabal before we merge this.

@hasufell
Copy link
Author

Let's wait until these changes land in an officially released cabal before we merge this.

Why? This works with any cabal version.

@hasufell hasufell closed this Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants