Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add options to phone number #51

Merged
merged 3 commits into from
Nov 27, 2023
Merged

feat: add options to phone number #51

merged 3 commits into from
Nov 27, 2023

Conversation

avallete
Copy link
Collaborator

Add more options to copycat.phoneNumber to:

  1. Be able to control generated phone number length
  2. Be able to provide invalid prefixes to make sure you won't dial a real phone number by mistake.

jgoux
jgoux approved these changes Nov 27, 2023
View reviewed changes
Copy link

@jgoux jgoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

@avallete avallete merged commit 5439caf into next Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgoux jgoux jgoux approved these changes

@justinvdm justinvdm Awaiting requested review from justinvdm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avallete @jgoux