removed extra error check and owned service

snapp-incubator · Dec 11, 2023 · 9dd1af9 · 9dd1af9
1 parent 5b7a61b
commit 9dd1af9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/internal/controller/basic_authenticator/basicauthenticator_controller.go b/internal/controller/basic_authenticator/basicauthenticator_controller.go
@@ -65,7 +65,6 @@ func (r *BasicAuthenticatorReconciler) Reconcile(ctx context.Context, req ctrl.R
 func (r *BasicAuthenticatorReconciler) initVars(request ctrl.Request) {
 	r.basicAuthenticatorNamespace = request.Namespace
 	//configmap name and credential name's value would be set in reconcile loop
-
 }
 
 // SetupWithManager sets up the controller with the Manager.
@@ -75,6 +74,7 @@ func (r *BasicAuthenticatorReconciler) SetupWithManager(mgr ctrl.Manager) error
 		Owns(&appv1.Deployment{}).
 		Owns(&corev1.ConfigMap{}).
 		Owns(&corev1.Secret{}).
+		Owns(&corev1.Service{}).
 		Watches(
 			&source.Kind{Type: &appv1.Deployment{}},
 			handler.EnqueueRequestsFromMapFunc(r.findExternallyManagedDeployments),

diff --git a/internal/controller/basic_authenticator/provision.go b/internal/controller/basic_authenticator/provision.go
@@ -244,10 +244,8 @@ func (r *BasicAuthenticatorReconciler) createDeploymentAuthenticator(ctx context
 		r.logger.Info("created deployment")
 		r.deploymentLabel = newDeployment.Spec.Selector
 	} else if err != nil {
-		if err != nil {
-			r.logger.Error(err, "failed to fetch deployment")
-			return subreconciler.RequeueWithError(err)
-		}
+		r.logger.Error(err, "failed to fetch deployment")
+		return subreconciler.RequeueWithError(err)
 	} else {
 		//update deployment
 		targetReplica := newDeployment.Spec.Replicas