Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[whitelist-weighted-json] New strategy #1480

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

thierbig
Copy link
Contributor

@thierbig thierbig commented May 20, 2024

Adds a new strategy to circumvent the max limit of the whitelist-weighted strategy
Changes proposed in this pull request:

  • Add a new strategy called whitelist-weighted-json strategy. The strategy uses a hosted json file that will allow bigger whitelists to be sent

@thierbig thierbig changed the title Add whitelist-weighted-json strategy [whitelist-weighted-json] Add whitelist-weighted-json strategy May 20, 2024
@thierbig thierbig changed the title [whitelist-weighted-json] Add whitelist-weighted-json strategy [whitelist-weighted-json] New strategy May 20, 2024
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thierbig Make sure the tests are passing, try running yarn test --strategy=whitelist-weighted-json in your local, Also I'd suggest you to use api-v2 strategy and format your JSON accordingly

@thierbig
Copy link
Contributor Author

Hi @ChaituVR. All the tests are now passing. The api-v2 strategy has been giving me trouble and I think the strategy I'm introducing will be easy to use for newcomers to the platform like myself.

@ChaituVR ChaituVR merged commit 8f06509 into snapshot-labs:master May 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants