[erc20-votes-with-override] Adding ERC-20 votes with override strategy. #448
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
ChaituVR
changed the title
|
@ChaituVR Thank you! Addressed those comments about Object/Record, all checks are passing now :) |
| If getVotes returns a nonzero value, then that is used. Then any delegators | ||
| that have individually voted will have their balances subtracted from the | ||
| result. | ||
|
|
There was a problem hiding this comment.
How do the getVotes know that users have already voted? Sorry @serenae-fansubs Trying to get my brain around it :)
There was a problem hiding this comment.
That's the OpenZeppelin getVotes method, and really maybe it would have made more sense if they called it "getVotingPower" or something, I can see the confusion. That method is just retrieving the total sum of that account's delegated voting power.
There was a problem hiding this comment.
@ChaituVR it's the same method used in the regular erc20-votes strategy: https://github.com/snapshot-labs/snapshot-strategies/blob/master/src/strategies/erc20-votes/index.ts#L24
There was a problem hiding this comment.
I also updated the comments there to make it more clear that it's talking about voting power, and refactored to make it a bit easier to follow.
This also catches an edge case where an account is delegating to someone else, has a balance, and also has votes because someone else is delegating to them. The votes returned from getVotes are always counted no matter what, just like in the erc20-votes strategy. The local token balance is only added when an account is delegating to different valid address.
Addresses #449.
This strategy is similar to ERC-20 Votes, except that it also allows individual delegators to override their vote on a particular proposal if they wish. This is most useful for social (off-chain only) proposals.
If an account has any delegated voting power returned from getVotes, adds that value, minus the balances from any delegators that have also individually voted.
If an account is delegating to itself, then its own token balance will already be included in the getVotes return value.
If an account is delegating to a different valid address, adds the local token balance. The account must be delegated to another valid address, otherwise the local token balance will not be added.