Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass headers to score API #757

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pass headers to score API #757

wants to merge 2 commits into from

Conversation

ChaituVR
Copy link
Member

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #757 (63fe7c3) into master (70c7df8) will decrease coverage by 0.11%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master     #757      +/-   ##
==========================================
- Coverage   60.48%   60.37%   -0.11%     
==========================================
  Files          14       14              
  Lines        1321     1325       +4     
  Branches      165      165              
==========================================
+ Hits          799      800       +1     
- Misses        521      524       +3     
  Partials        1        1              
Impacted Files Coverage Δ
src/utils.ts 25.70% <11.11%> (-0.01%) ⬇️

@wa0x6e
Copy link
Contributor

wa0x6e commented Nov 6, 2023

Can you resolve conflicts ? This is an useful update

Comment on lines 294 to +295
Accept: 'application/json',
'Content-Type': 'application/json'
'Content-Type': 'application/json',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be extract into a jsonHeaders object, and reused like ...jsonHeaders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants