Restructure repo #102
Merged
Restructure repo #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pscott
approved these changes
May 2, 2022
.github/workflows/lint.yml
Outdated
| @@ -46,4 +46,4 @@ jobs: | |||
|
|
|||
| - name: Run Linters | |||
| run: | | |||
| yarn check-format | |||
| yarn format | |||
There was a problem hiding this comment.
I think we should stick with check-format here and have the CI only throw an error when code is not formatted properly. If we run format here, basically it will format the code for the CI, but not commit it, so our codebase will remain unformatted I think
There was a problem hiding this comment.
oh i see yes will revert
| %lang starknet | ||
|
|
||
| @contract_interface | ||
| namespace i_authenticator: |
There was a problem hiding this comment.
inb4 @bonustrack fires you for writing this 👺👺👺
There was a problem hiding this comment.
i just love snake case so much, cant help it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo Restructuring and Renaming to increase consistency and readability.