Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space factory #197

Merged
merged 26 commits into from
Jul 25, 2022
Merged

Space factory #197

merged 26 commits into from
Jul 25, 2022

Conversation

Orland0x
Copy link
Contributor

@Orland0x Orland0x commented Jun 21, 2022

Adds a factory to enable the creation of a space. We can then track space creations using by monitoring the space_deployed event using checkpoint.

The space creation event within Space.cairo is then made redundant so we remove that also.

closes #179

@Orland0x Orland0x marked this pull request as ready for review July 13, 2022 17:43
@Orland0x Orland0x requested a review from pscott July 13, 2022 17:43
Copy link
Contributor

@pscott pscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

contracts/starknet/SpaceFactory.cairo Outdated Show resolved Hide resolved
);

const spaceFactoryClass = await starknet.getContractFactory('./contracts/starknet/Space.cairo');
const spaceHash = await spaceFactoryClass.declare();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see how it's done! :)

@Orland0x Orland0x merged commit 08f0a5e into develop Jul 25, 2022
@Orland0x Orland0x deleted the space_factory branch August 1, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space Factory
2 participants