Fix eth sig failure #295
Merged
Fix eth sig failure #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pscott
force-pushed
the
fix_eth_sig_failure
branch
from
e9715dc
to
526ceaf
Compare
…ng it at the end of the source array
|
This PR also brings back the tweak to |
Orland0x
approved these changes
Aug 23, 2022
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After investigation, I found that calling
.addressin starknet.js would actually left pad the address with some zeroes.In the cairo code however, I was right-padding with zeroes (as specified in EIP-712....).
This PR removes the right-padding done on the
spaceaddress in the cairo code.The
proposer_address/voter_addressare not padded because they are 20 bytes long and effectively right padded when constructing the EIP-712 hash in js... :)Closes #292