Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
assert_no_duplicates
function that will throw if duplicates are found in an array. This function is doing this the "dumb way" (i.e. for each element, loop through the array and make sure there a no duplicates, resulting in O(n^2) complexity). The good thing about this is that no builtins are used whatsoever: so it's step intensive but builtin lightweight.Another way we could do this is by using the
bitwise builtin
. Since most spaces will probably not support a gazilion voting strategies, I think we're fine with that, but we could indeed other ways of doing this in the future (sorting by increasing order for example to make lookup faster...)Call this function in
get_cumulative_voting_power
to make sure voting strategies are unique.Closes #298