Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize even if quorum has not been reached #342

Merged
merged 6 commits into from
Sep 24, 2022

Conversation

pscott
Copy link
Contributor

@pscott pscott commented Sep 23, 2022

Fixes #339 !

Also renames add_executors / remove_executors to add_execution_strategies / remove_execution_strategies

@pscott pscott force-pushed the finalize_even_if_quorum_has_not_been_reached branch from ce8ff3e to 544e71d Compare September 23, 2022 11:15
Copy link
Contributor

@Orland0x Orland0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pscott pscott merged commit b4d78a2 into develop Sep 24, 2022
@Orland0x Orland0x deleted the finalize_even_if_quorum_has_not_been_reached branch September 27, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal can't be finalized if quorum hasn't been reached
2 participants