Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Felt math #362

Merged
merged 9 commits into from
Oct 19, 2022
Merged

Felt math #362

merged 9 commits into from
Oct 19, 2022

Conversation

Orland0x
Copy link
Contributor

@Orland0x Orland0x commented Oct 4, 2022 •
edited
Loading

Went through mathematical asserts / comparisons and made a few updates. Also used OZ Uint2656 safemath for voting power aggregation

pscott
pscott approved these changes Oct 18, 2022
View reviewed changes
contracts/starknet/lib/voting.cairo Show resolved Hide resolved
contracts/starknet/lib/voting.cairo Show resolved Hide resolved
pscott
pscott approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@pscott pscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using assert_le_felt (i.e using treating the input as unsigned instead of signed numbers)?

@Orland0x
Copy link
Contributor Author

Should we be using assert_le_felt (i.e using treating the input as unsigned instead of signed numbers)?

resolved on discord

@pscott
Copy link
Contributor

pscott commented Oct 19, 2022

I think we can squash and merge then :)

@Orland0x Orland0x merged commit f9343c6 into develop Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pscott pscott pscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Orland0x @pscott