Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all uint256 are valid #370

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Make sure all uint256 are valid #370

merged 2 commits into from
Oct 20, 2022

Conversation

pscott
Copy link
Contributor

@pscott pscott commented Oct 20, 2022

Closes #369

@Orland0x Orland0x marked this pull request as ready for review October 20, 2022 13:52
Orland0x
Orland0x approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@Orland0x Orland0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Orland0x
Copy link
Contributor

We could combine FeltUtils and Uint256Utils into a single lib called MathUtils or something?

@pscott
Copy link
Contributor Author

pscott commented Oct 20, 2022 •
edited by Orland0x
Loading

Good idea!

@Orland0x
Copy link
Contributor

Good idea!

Cool, Ill do it on the formatting PR

@Orland0x Orland0x merged commit c71f8f3 into develop Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orland0x Orland0x Orland0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add uint256_check() for every uint256
2 participants
@pscott @Orland0x