add Choice enum #44
Merged
add Choice enum #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonustrack
reviewed
Feb 28, 2022
| @@ -0,0 +1,4 @@ | |||
| namespace Choice: | |||
| const YES = 0 | |||
There was a problem hiding this comment.
If we can use 0, I suggest we simply use the same format from OpenZeppelin Governor which is:
Against = 0
For = 1
Abstain = 2
bonustrack
approved these changes
Feb 28, 2022
ShahakShama
force-pushed
the
shahak/choice
branch
from
ab2aa10
to
cdf577b
Compare
|
I was under the impression that we couldn't use 0 for one of the choices as it was the default value. Is this not an issue here? |
|
I initially thought this won't be a problem because we don't have a storage var for choice only, but it's better this way anyway just to be safe :) |
Orland0x
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.