Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla authenticator #45

Merged
merged 13 commits into from
Mar 3, 2022
Merged

Vanilla authenticator #45

merged 13 commits into from
Mar 3, 2022

Conversation

pscott
Copy link
Contributor

@pscott pscott commented Mar 1, 2022

As per what was described in milestone1, here is a vanilla authenticator contract that does not check any signature and only forwards the call.

@Orland0x Orland0x self-requested a review March 1, 2022 12:53
@Orland0x
Copy link
Contributor

Orland0x commented Mar 1, 2022

looks good

@pscott
Copy link
Contributor Author

pscott commented Mar 3, 2022

Tests are failing because we need to define the SPACE_CONTRACT if we wish to interact with it :p But at least we've got the code required to interact with the authenticator contracts (useful for @bonustrack :))

@pscott
Copy link
Contributor Author

pscott commented Mar 3, 2022

I suggest merging this bad boy (I commented out the tests for the vanilla auth), so that I can then merge develop into the other branch (vanilla_space). Since both branches need each other, I think it's the only way :) (or we could directly merge this branch in vanilla_space) but I think it's cleaner to merge this one into develop first. @bonustrack wdyt? :)

Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound good!

@pscott pscott merged commit 0dc1be5 into develop Mar 3, 2022
@Orland0x Orland0x deleted the vanilla_auth branch May 4, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants