Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sticky prop to Label #428

Merged
merged 2 commits into from
Feb 13, 2023
Merged

feat: add sticky prop to Label #428

merged 2 commits into from
Feb 13, 2023

Conversation

j0hnfl0w
Copy link
Contributor

Closes: #418

  • added sticky prop, without default state
  • removed overflow-hidden from App wrapper div, cos sticky wont work with it source

@j0hnfl0w @bonustrack
Update src/components/Label.vue
af184e4 
Co-authored-by: Fabien <bonustrack@users.noreply.github.com>
bonustrack
bonustrack approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Sekhmet
Sekhmet approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@Sekhmet Sekhmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@bonustrack bonustrack merged commit ecea212 into snapshot-labs:master Feb 13, 2023
Sekhmet pushed a commit to snapshot-labs/sx-monorepo that referenced this pull request Feb 6, 2024
@j0hnfl0w @bonustrack
feat: add sticky prop to Label (snapshot-labs/sx-ui#428)
a9f505c 
* feat: add sticky prop to Label

* Update src/components/Label.vue

Co-authored-by: Fabien <bonustrack@users.noreply.github.com>

---------

Co-authored-by: Fabien <bonustrack@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sekhmet Sekhmet Sekhmet approved these changes

@bonustrack bonustrack bonustrack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

style: option for sticky label bars
3 participants
@j0hnfl0w @Sekhmet @bonustrack