Remove unsupported VAG module #1331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remark: This would also render the ID and the (anyway out of order) Audi module useless, as they are also calling on the evcc-soc binary. For VW the cost free option remains with carnet (10% soc increment) and for ID only Tronity and EVCC with token would remain. Impact on customer satisfaction by shutting down a working (but unsupported) model needs to be considered |
|
Ja, da stimme ich zu, passt so. Der Testtoken läuft wie lang? |
|
Bin mir nicht sicher wann der abläuft- bei Bedarf kann ich aber jederzeit neue erzeugen. Einfach melden. |
|
|
@benderl das alte Modul kann entfernt werden. VW hat das Login geändert- das wird nie wieder funktionieren. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unsupported VAG module.
Rationale
OpenWB has suggested to externalize maintenance of the SoC modules: https://openwb.de/forum/viewtopic.php?f=11&t=2841. The VAG module is based on outdated and unmaintained evcc-soc (Github Repo archived). As original author I'm receiving support requests for this outdated module that I cannot provide. With #1296 a currently maintained module has been added providing the same functionality plus ongoing support.