Improve error logging if EVNotify SoC cannot be retrieved #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That was quick, thx. However something is still wrong. Nothing is logged. I searched around for a bit and I could not find anything wrong with the code. However I tested my code only with python3. It is not compatible with python2. I have no idea what the installed version of python and the default is... However I see that many script call explicitly |
This was referenced Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like in the moment EVNotify integration with openWB is broken. I have no idea why. I check the source code and if I try to imitate what it is doing locally it works fine.
However the current implementation does not give good log messages. Like what is the actual response from EVNotify? Was there maybe a non 2xx response?
This PR does not fix the underlying problem, but improves error logging if something is wrong. Hopefully it helps to identify the problem linked and other similar problems in the future.
Note that I only tested the code isolated in my stubbed development environment. It still needs to be tested on an actual system.