Modification of smarthomehandler.py for smarthome module smaem #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change: No parameter for debugmode anymore - Change: Always write debuglog smaem.log Parameter secondssincelastmetering is not used right now, instead of using parameter it will static use 15 seconds
- usage of given parameter for secondssincelastmetering - coding changed to ISO-8859-1 - former debug switches removed - Debug output modified, now with timestamps
change of comment block
Modification for handover GUI parameter for smarthome module smaem "SMA EnergyMeter"
Modification of watt.py: We now calculate the seconds since last ret-file creation only based on seconds (no milliseconds anymore) We don't accept "any"/"None" SMA serial number anymore as we assume that our SMA EnergyMeter is not alone in our network. Some comments are hopefully more self-explaining
We now use a separate file to avoid that a "normal" smarthome metering also writes the return-file
|
Kannst Du Deinen Fork bitte auf den aktuellen Master aktualisieren und den Branch rebasen? |
|
Ich habe eigentlich quasi jede Änderung dokumentiert - aber ich vermute das war evtl. das falsche Feld. Wenn man auf die drei Punkte klickt, werden meine Kommentare angezeigt. |
|
|
|
Ok, danke für den Hinweis. Comment ist hinterlegt. |
|
The PR is broken and will be replaced by 1651 and 1655 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification of smarthomehandler.py regarding parameters for smarthome module smaem (SMA EnergyMeter)
Changes of smaem/watt.py for functional enhancement, log improvement and GUI parameters
With this pull request, the module is functional ready.
Known issues regarding dummyurl2 (see Wiki article)