Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socvwid p7 #2302

Merged
merged 5 commits into from Jul 19, 2022
Merged

Socvwid p7 #2302

merged 5 commits into from Jul 19, 2022

Conversation

rleidner
Copy link
Contributor

Current approach forces a new login in the VW Servers on each inquiry of the SOC.
This may cause a reaction on VW side in form of additional measures to make programmatic access from non-VW clients more difficult.
The unrequired login also costs about 50% of the total runtime.

Each login returns a new set of tokens.

The PR stores the tokens to a file in ramdisk (soc_vwid_tokensX (X=number of Ladepunkt).
On each query the tokens file is restored to the tokens in the vwid object and the tokens are reused until they become invalid.
If invalid the new tokens are stored in the file.

Tests done:

  • Run without existing tokens file: works, SoC is returned, new file is created.
  • Run with existing and valid tokens file: works, SoC is returned
  • Run with existing but invalid tokens file: SoC is returned, new file is created.
  • Run with tokens file owned by root: permission error is handled

Credits to gvz for the hint: https://openwb.de/forum/viewtopic.php?p=68055#p68055

@rleidner
Copy link
Contributor Author

Still testing, please don't merge yet ...

@rleidner
Copy link
Contributor Author

Fixes done, latest version can be merged to nightly

@benderl
Copy link
Collaborator

benderl commented Jul 19, 2022

Wenn Du gerade schon dran bist, kannst Du bitte alle fixen Verweise auf /var/www/html/openWB/... entfernen und das relativ lösen? Analog zu dem $OPENWBBASEDIR in der main.sh.

@rleidner
Copy link
Contributor Author

Hallo Lutz,
guter Hinweis :-)
Die Pfade sind jetzt relativ zu RAMDISKDIR.

@benderl benderl merged commit ecf9a36 into snaptec:master Jul 19, 2022
@rleidner rleidner deleted the socvwid_p7 branch February 28, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants