Make the semantics of Stream more reasonable
#221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
reviewed
Mar 22, 2022
sdroege
reviewed
Mar 22, 2022
|
|
||
| // The connection has been closed or the critical error has occurred. | ||
| // We have already returned the error to the user, the `Stream` is unusable, | ||
| // so we assume that the stream has been "fused". |
There was a problem hiding this comment.
You probably also want to implement futures::stream::FusedStream then
There was a problem hiding this comment.
Oh, great suggestion! Thanks. Done.
daniel-abramov
force-pushed
the
improve-stream-none-semantics
branch
from
9b9526e
to
cb9144e
Compare
sdroege
approved these changes
Mar 23, 2022
gregates
pushed a commit
to gregates/tokio-tungstenite
that referenced
this pull request
Feb 24, 2024
…gger-0.9.0 Update env_logger requirement from 0.8.1 to 0.9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200.