Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose danger_connect and danger_client_async_tls #41

Closed
wants to merge 2 commits into from
Closed

Expose danger_connect and danger_client_async_tls #41

wants to merge 2 commits into from

Conversation

mehcode
Copy link
Contributor

@mehcode mehcode commented Jun 19, 2018

Re-implementation of #34 on top of #40

daniel-abramov added a commit that referenced this pull request Jul 19, 2018
@daniel-abramov
Update to the newest tungstenite-rs version
b61ed96 
* Fixes #35
* Replaces #40
* Gives a good background for #41
@daniel-abramov daniel-abramov mentioned this pull request Jul 19, 2018
Merged
@daniel-abramov
Copy link
Member

Thanks @mehcode , would you be up for rebasing the pull request on master and make the corresponding changes? I have recently updated the tokio-tungstenite master branch to match the new released version of tungstenite-rs.

Please let me know if you don't have time to work on it and I'll try to re-make the changes on top of the master branch.

@daniel-abramov daniel-abramov mentioned this pull request Jul 24, 2018
Closed
@mehcode
Copy link
Contributor Author

mehcode commented Aug 9, 2018

Going to close this for now because it probably requires some more thought or more of a rework of the API than I expected.

Instead of adding danger_* methods I vote we instead offer a builder interface version of connect that forwards configuration found on https://docs.rs/native-tls/0.2.1/native_tls/struct.TlsConnectorBuilder.html

@mehcode mehcode closed this Aug 9, 2018
@elbaro elbaro mentioned this pull request Jul 9, 2020
Closed
black02430horse added a commit to black02430horse/tokio-tungstenite that referenced this pull request Apr 25, 2024
@black02430horse
Update to the newest tungstenite-rs version
865ca18 
* Fixes #35
* Replaces snapview/tokio-tungstenite#40
* Gives a good background for snapview/tokio-tungstenite#41
x-610 added a commit to x-610/tokio-tungstenite that referenced this pull request May 13, 2024
@x-610
Update to the newest tungstenite-rs version
a69a812 
* Fixes #35
* Replaces snapview/tokio-tungstenite#40
* Gives a good background for snapview/tokio-tungstenite#41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mehcode @daniel-abramov