Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP => Bluesky: reply to reply didn't set root separate from parent #1007

Closed
snarfed opened this issue May 5, 2024 · 3 comments
Closed

AP => Bluesky: reply to reply didn't set root separate from parent #1007

snarfed opened this issue May 5, 2024 · 3 comments
Labels

Comments

@snarfed
Copy link
Owner

snarfed commented May 5, 2024

Reported by @mackuba, thanks again!

wrong reply root uri set (it's set to the same as parent, even though parent wasn't the root)
https://bsky.app/profile/BeAware.social.beaware.live.ap.brid.gy/post/3krjdlcvw3sh2
notice that the second reply ("Yo" from RxBrad) is shown as having 2 replies in the status line, but there's only one direct reply visible
there's a second reply from OP (BeAware) that's not visible on bsky.app
root should be at://did:plc:l7l5l65nk5aogxmspxaqd5go/app.bsky.feed.post/3krjdlcvw3sh2 and not at://did:plc:zy5eyl3a7ut4vxzfjjdtysh2/app.bsky.feed.post/3krje5fbm332r

@mackuba
Copy link

mackuba commented May 5, 2024

I was just going to add it here :) but I have a few more issues to add 😈

@mackuba
Copy link

mackuba commented May 5, 2024

@snarfed
Copy link
Owner Author

snarfed commented May 16, 2024

Fixed! Example: https://indieweb.social/@snarfed/112452723190652012 => https://bsky.app/profile/snarfed.indieweb.social.ap.brid.gy/post/3ksn3e5akcq42

...and phew, this was a project. Substantial refactoring to unify on granary's logic for populating strongRefs etc, but with our stored records. Thanks again for reporting @mackuba.

@snarfed snarfed closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants