Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually verify incoming signatures 馃お #315

Closed
snarfed opened this issue Nov 23, 2022 · 4 comments
Closed

Actually verify incoming signatures 馃お #315

snarfed opened this issue Nov 23, 2022 · 4 comments

Comments

@snarfed
Copy link
Owner

snarfed commented Nov 23, 2022

alright alright alright fine

# TODO: verify signature if there is one

@snarfed
Copy link
Owner Author

snarfed commented Jan 15, 2023

Downside: this would require fetching AS2 actors and keys for a wide range of incoming AP activities, which we don't currently have to bother with.

@snarfed
Copy link
Owner Author

snarfed commented Jan 27, 2023

This will be easier after #286

@snarfed
Copy link
Owner Author

snarfed commented Feb 16, 2023

This is working! One catch: Deletes are signed with the deleted actor's key, which we often don't have, and when we try to fetch it, we predictably get 410 Gone. We only recently started storing (and fetching) actors, so maybe those actors got sent to us before, and their instances think we should already have their keys?

@snarfed
Copy link
Owner Author

snarfed commented Feb 26, 2023

Those requests faded once we started fetching and storing inner objects. Sigs have all been passing for a week now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant