Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing webmention targets for Flickr #536

Closed
kylewm opened this issue Nov 3, 2015 · 12 comments
Closed

Missing webmention targets for Flickr #536

kylewm opened this issue Nov 3, 2015 · 12 comments
Assignees
Labels

Comments

@kylewm
Copy link
Contributor

kylewm commented Nov 3, 2015

https://www.flickr.com/photos/davidpeach1/22566349100/#comment72157660752428702

seems to have everything in the right but Bridgy is not finding a webmention target for some reason.

cc @davidpeach sorry for the trouble!

@kylewm
Copy link
Contributor Author

kylewm commented Nov 4, 2015

Diagnosis: missing comma was causing us to ask flickr for "descriptiontags" instead of "description,tags" and it was silently failing. Which meant we weren't seeing the description field at all, which meant no permalink.

Confirmed working in https://kylewm.com/2015/08/last-weekend-we-walked-the-new-devil-s-slide-trail

@snarfed
Copy link
Owner

snarfed commented Nov 4, 2015

oh man, these kinds of bugs are the best. thanks for the fix!

@davidpeach
Copy link

My endpoints still aren't connecting - they still say no webmention
endpoints?

On 04/11/15 15:04, Ryan Barrett wrote:

oh man, these kinds of bugs are the best. thanks for the fix!


Reply to this email directly or view it on GitHub
#536 (comment).

@snarfed
Copy link
Owner

snarfed commented Nov 4, 2015

@kylewm looking at @davidpeach's latest poll, the commas in the extras param are URL encoded, ie &2Cs. is that expected?

@kylewm
Copy link
Contributor Author

kylewm commented Nov 4, 2015

hmm, yes it is expected. looking...

@kylewm kylewm reopened this Nov 4, 2015
@kylewm
Copy link
Contributor Author

kylewm commented Nov 4, 2015

Flickr users apparently have both username (davidpeach) and path_alias (davidpeach1). We need to use the latter (if it exists) when canonicalizing URLs, for posse post discovery to work.

Not sure if I should store both fields and use path_alias for canonicalization and username for everything else, or if I should just use path_alias in place of username.

@kylewm
Copy link
Contributor Author

kylewm commented Nov 4, 2015

@davidpeach can you try to re-auth bridgy so it picks up the appropriate alias?

@snarfed
Copy link
Owner

snarfed commented Nov 4, 2015

ah, nice find. are those fields in FlickrAuth.user_json? if so you could just use them from there. i do that in other sources. otherwise i vote for storing both fields.

@snarfed
Copy link
Owner

snarfed commented Nov 4, 2015

woo! looks like this was fixed by e1b987e. https://brid.gy/flickr/78445135@N05#responses shows the test responses were sent ok. tentatively closing. thanks @kylewm! and thanks @davidpeach for the report!

@snarfed snarfed closed this as completed Nov 4, 2015
@kylewm
Copy link
Contributor Author

kylewm commented Nov 4, 2015

@snarfed except I did the thing that was the opposite of your preference (replacing username with path_alias); would you still rather store both?

@davidpeach
Copy link

Works like a charm. I opened up my site admin to find three lovely web mentions awaiting my approval.

Thanks again to you both.

On 4 November 2015 21:51:00 GMT+00:00, Kyle Mahan notifications@github.com wrote:

@snarfed except I did the thing that was the opposite of your
preference (replacing username with path_alias); would you still rather
store both?


Reply to this email directly or view it on GitHub:
#536 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@snarfed
Copy link
Owner

snarfed commented Nov 4, 2015

@kylewm they're both in user_json, so we do have them both available at least, so i'm fine with this. thanks for asking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants