Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement account delete for Bluesky #1594

Merged
merged 1 commit into from Nov 2, 2023
Merged

implement account delete for Bluesky #1594

merged 1 commit into from Nov 2, 2023

Conversation

snarfed
Copy link
Owner

@snarfed snarfed commented Nov 1, 2023 •
edited

fixes #1593

apologies, 42e9235 should have been part of this PR too. ah well 馃榾

@snarfed
Copy link
Owner Author

snarfed commented Nov 1, 2023

Hey @JoelOtter, mind taking a look to see if I missed anything obvious here? Not urgent.

JoelOtter
JoelOtter approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@JoelOtter JoelOtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Though honestly I don't know much about the deletion code paths at all

@snarfed
Copy link
Owner Author

snarfed commented Nov 2, 2023

Thanks!

@snarfed snarfed merged commit 37a896d into main Nov 2, 2023
7 checks passed
@snarfed snarfed deleted the delete-bluesky branch November 2, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelOtter JoelOtter JoelOtter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement delete for Bluesky
2 participants
@snarfed @JoelOtter