support for bridgy_omit_link=maybe #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not quite ready yet... |
|
OK now I'm done, and it's live on https://bridgy-kwm.appspot.com/ (CI checks are failing because this depends on snarfed/granary#86) |
| </label> | ||
| <label> | ||
| <input id="omit-link-maybe" name="bridgy_omit_link" value="maybe" type="radio"> | ||
| if shortened |
There was a problem hiding this comment.
minor, consider an alt tooltip with a more detailed explanation?
There was a problem hiding this comment.
Good idea! Also reminded me I meant to add it to the docs too.
|
lgtm yay! especially if you've tested manually that interactive still works w/o js as well as with. :P thanks again! |
interpret bridgy_omit_link=maybe as "include link iff the content is shortened". fixes snarfed#561
kylewm
force-pushed
the
omit-maybe
branch
2 times, most recently
from
dfc0a5a
to
80a0d46
Compare
|
🎵 well I just met you |
|
@snarfed it acts weird with the cached bridgy.js -- do you do any kind of |
|
sadly no, but its expiration is only 1h. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interpret bridgy_omit_link=maybe as "include link iff the content is
shortened".
(my 2-line-fix ended up being more like 300 lines across 11 files ... nice estimation abilities, me)
fixes #561