Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is AS1 tag.length characters/graphemes? or UTF-8 bytes? or...? #705

Open
snarfed opened this issue Apr 1, 2024 · 1 comment
Open

is AS1 tag.length characters/graphemes? or UTF-8 bytes? or...? #705

snarfed opened this issue Apr 1, 2024 · 1 comment

Comments

@snarfed
Copy link
Owner

snarfed commented Apr 1, 2024

I think in practice we treat it as Unicode characters/graphemes, but I don't think we're consistent about it, eg I think right now we convert it to Bluesky byteStart/End directly, without encoding to bytes first.

Doesn't matter in practice much because most of our data sources - microformats2 HTML, fediverse AS2 activities, etc - don't have explicit tag indices. Still though, even internally, this will bite us eventually.

@snarfed
Copy link
Owner Author

snarfed commented May 18, 2024

We've been interpreting it as unicode chars ie graphemes. Let's standardize on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant