Skip to content
This repository has been archived by the owner on Apr 15, 2023. It is now read-only.

feature request: move images to atom enclosures #3

Closed
aaronpk opened this issue Nov 30, 2017 · 6 comments
Closed

feature request: move images to atom enclosures #3

aaronpk opened this issue Nov 30, 2017 · 6 comments

Comments

@aaronpk
Copy link

aaronpk commented Nov 30, 2017

I'd love to see the instagram photos added as atom enclosures rather than being embedded in the HTML. When I run an instagram-atom feed through XRay to convert it to the jf2 format used by my new reader, right now the images just appear in the embedded HTML. Ideally they'd show up in XRay's photo property, but I can only do that if they're marked as atom enclosures. Maybe this could be a query string parameter to change the behavior since I know some feed readers won't support that attachment very well.

@snarfed
Copy link
Owner

snarfed commented Nov 30, 2017

sure! worth considering. looks like we also investigated this somewhat thoroughly a bit ago in snarfed/granary#113.

@snarfed
Copy link
Owner

snarfed commented Dec 2, 2017

interesting, just found another alternative, at least for single photo/video posts: they could be the top-level content, e.g. <content type="image/png" src="/mypng1.png" />. full example: https://www.ibm.com/developerworks/library/x-atom10/index.html#N10119

no idea how reader support for this is. probably even worse than for image enclosures...which is already the main reason i'm reluctant here. :/

snarfed added a commit to snarfed/granary that referenced this issue Dec 5, 2017
fixes #120...but by dropping the <img> *outside* content, not the one inside as requested. that may still be the right long term answer, but right now it's reused as atom content, and we're still debating whether we want to move that to an enclosure in #113 and snarfed/instagram-atom#3. reader support seems unclear at best.
@Nick-Shannon
Copy link

Hi, the instagram-atom is great.
However, my feed is broken :(.

FYI, I added the instagram-atom feed to Feed Burner. I've also use an IFTTT applet to post my instagram feed toa private twitter account - so I can have my Instagram in my Twitter :).
The IFTTT applet requires: {{EntryImageUrl}}

Has there been a recent change to the instagram-atom tool?

snarfed added a commit to snarfed/granary that referenced this issue Dec 9, 2017
@snarfed
Copy link
Owner

snarfed commented Dec 9, 2017

thanks for reporting, @Nick-Shannon! looks like there was a minor Atom validation error. i've fixed it and pushed the update. let me know if your feed is happy now! or if not, please post the specific error you're seeing and any other details.

@Nick-Shannon
Copy link

Thanks @snarfed. Feed is back to normal! Thanks for the rapid fix.

@snarfed
Copy link
Owner

snarfed commented Jan 3, 2018

done in snarfed/granary@92341ea. feel free to try @aaronpk!

@snarfed snarfed closed this as completed Jan 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants