Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Features #12

Merged
merged 1 commit into from Jul 19, 2015
Merged

Add New Features #12

merged 1 commit into from Jul 19, 2015

Conversation

dshanske
Copy link
Member

List in changelog.

@snarfed
Copy link
Member

snarfed commented Jul 17, 2015

woo, yay, congrats! i'll look soon. nice work!

@@ -20,6 +20,23 @@
// curl -i -d 'code=CODE&me=SITE&client_id=indieauth&redirect_uri=https://indieauth.com/success' 'https://tokens.indieauth.com/token'
// 4. Extract the access_token parameter from the response body.

// For debugging purposes this will bypass Micropub authentication
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh. did you notice that it doesn't require auth when it's running on localhost? given that, do you think still we want this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually test on a remote server. A $1 a month VPS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@snarfed
Copy link
Member

snarfed commented Jul 19, 2015

lgtm otherwise. thanks for your patience with me being so pedantic. :P ready to merge as soon as these last changes are in and the manual testing all works!

@snarfed
Copy link
Member

snarfed commented Jul 19, 2015

yay, thanks for sticking with this. congrats!

snarfed added a commit that referenced this pull request Jul 19, 2015
@snarfed snarfed merged commit 2b006b6 into indieweb:master Jul 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants