Pull token data from IndieAuth plugin #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snarfed
reviewed
Apr 26, 2018
micropub.php
Outdated
| @@ -175,6 +174,10 @@ public static function parse_query( $wp ) { | |||
| if ( ! empty( $indieauth_scopes ) ) { | |||
| static::$scopes = $indieauth_scopes; | |||
| } | |||
| global $indieauth_token; | |||
There was a problem hiding this comment.
huh. is this really an ok way for plugins to communicate?! seems like they should use hooks or filters instead?
There was a problem hiding this comment.
i do get that the code was already working this way, and this just extends that. still though.
There was a problem hiding this comment.
I am happy to see explore changibg it to a filter on both ends
There was a problem hiding this comment.
thanks! if you plan to switch to filters, feel free to merge this now and do that afterward.
|
@snarfed Switches to filters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when I use the IndieAuth endpoint, the auth response storage vanished. This restores that behavior.