Dependency and Documentation Improvement #145
Conversation
|
woo thank you! just fyi i'm away on a brief vacation, so it may take me a day or two to get to this. |
|
I will continue to work on PRs. |
readme.md
Outdated
| @@ -9,7 +9,7 @@ A [Micropub](http://micropub.net/) server plugin. Available in the WordPress plu | |||
|
|
|||
| Once you've installed and activated the plugin, try using [Quill](http://quill.p3k.io/) to create a new post on your site. It walks you through the steps and helps you troubleshoot if you run into any problems. After that, try other clients like [OwnYourGram](http://ownyourgram.com/), [OwnYourCheckin](https://ownyourcheckin.wirres.net/), [MobilePub](http://indiewebcamp.com/MobilePub), and [Teacup](https://teacup.p3k.io/). | |||
|
|
|||
| Supports the [full W3C Micropub CR spec](https://www.w3.org/TR/micropub/) as of 2016-10-18, except for the optional media endpoint. Media may be uploaded directly to the wordpress-micropub endpoint as multipart/form-data, or sideloaded from URLs. | |||
| Supports the [full W3C Micropub CR spec](https://www.w3.org/TR/micropub/) as of version 2.0.0 | |||
There was a problem hiding this comment.
very minor nit: needs a period at the end.
There was a problem hiding this comment.
woo! thank you for docs! i don't have much (any) experience with travis or phpcs, so i'm pretty useless reviewing this. all i have is a typo. :P hey @pfefferle, any chance you could take a look?
|
@snarfed The update actually revealed some mistakes I made in the tests, which made it worth doing. It also now tests 7.2 and 5.4, which makes sense considering the plugin says it supports 5.3 and above. The phpcs update is because the WordPress Coding standard finally hit 1.0 and the VIP standards are merged in. So, I have to do that for all my projects. |
includes/class-micropub-endpoint.php
Outdated
| @@ -49,8 +49,18 @@ public static function return_micropub_error( $response, $handler, $request ) { | |||
| return $response; | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
| public static function log_error( $message, $name = '' ) { | |||
There was a problem hiding this comment.
If you set 'Micropub' as default for $name, you do not have to check in line 59.
includes/class-micropub-endpoint.php
Outdated
| $message = wp_json_encode( $message ); | ||
| } | ||
| if ( ! is_string( $name ) || empty( $name ) ) { | ||
| $name = 'Micropub: '; |
There was a problem hiding this comment.
Replace $name = 'Micropub: '; with $name = 'Micropub'; becaue the : is set by the error logger in line 62
|
Travis and PHPCS looks good to me... @dshanske Have you thought about an auto-releaser, like we use for the other IndieWeb plugins? |
|
@pfefferle I thought about an autoreleaser. I also use a push script for several plugins as well. I figured I'd defer to snarfed. |
|
If he's interested, I'd do it. |
* master: Fix php notices (indieweb#149) Move permissions to be checked before all other actions (indieweb#148) Dependency and Documentation Improvement (indieweb#145) Introduce REST API endpoint (indieweb#143)
This starts the process of updating the README, as well as updates the dependencies, notes PHPUnit as a composer dependency so it could be installed as part of the development package, and moves error_log to an error function inside the endpoint, opening the door for future customization. It also removes a call to an activation hook that isn't there.