Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bench): poseidon-merkle tree #287

Closed
wants to merge 26 commits into from
Closed

feat(bench): poseidon-merkle tree #287

wants to merge 26 commits into from

Conversation

cyphersnake
Copy link
Collaborator

Motivation
Close #285

Overview
WIP

@cyphersnake cyphersnake self-assigned this Jun 24, 2024
@cyphersnake
feat: add spans
51cf8e8
@cyphersnake
feat(example): merkle-tree benchmark
ca96e93
@cyphersnake
fix(bench): black box for input
2a4cdad
@cyphersnake
chore: update benchmark prop
eb394b0
@cyphersnake
fix(bench): commitment-size for merkle
cd10b32
@cyphersnake
feat(bench): add verify benchmark
580c391
@cyphersnake
feat(bench): make batch at ivc level
9b285b1
@cyphersnake
fix(bench): name for benchmark
d083f48
@cyphersnake
feat(bench): add step_batch_size
8d1f893
@cyphersnake
feat(bench): make circuit size param
3a54645
@cyphersnake
fix(bench): name of benchmarks
e524d97
@cyphersnake
feat(cli): add merkle-tree
8a1d05e
@cyphersnake
fix(cli): rm wrong span
158012a
@cyphersnake
chore(cli): fix span name
2348ef2
@cyphersnake
refactor(cli): circuit metainfo handlers
ec45dcd
@cyphersnake
feat(script): add span fields to output
8afb5f4
@cyphersnake
feat(bench): optimize process_step
5e0d42a
@cyphersnake
feat(example): add test with halo2::Circuit for merkle
38ffc3f
@cyphersnake
feat(cli): span for prove-time
e46ebd7
@cyphersnake
fix(cli): steps count
079be70
@cyphersnake
chore(cli): span for leaves
0137973
@cyphersnake
fix(example): merkle-tree proof queue
196c1ae
@cyphersnake
refactor: start use only one halo2curves, ff, group
dc7126e 
**Motivation**
In order to use the kzg prover, we need to be able to pass a curve to
it, but a different version of halo2curves was used inside the project.
This change also means that we need to use the same version of ff &
group.

**Overview**
Basically it's just eliminating the technical debt of having multiple
versions of the same crates (halo2curves, ff, group), now they are
consistent, and also exported externally so that any crate that uses
Sirius can just reuse the same versions of crates
@cyphersnake
fix: rm commit scope
b878fb2
@cyphersnake
Merge branch '298-exec-scope' into 285-poseidon-merkle-tree-benchmark
9e79471
@cyphersnake
feat: migrate to new halo2
b61f30d
@cyphersnake cyphersnake force-pushed the 285-poseidon-merkle-tree-benchmark branch from c7c1d80 to b61f30d Compare July 10, 2024 21:47
@cyphersnake cyphersnake mentioned this pull request Jul 11, 2024
Merged
cyphersnake added a commit that referenced this pull request Jul 11, 2024
@cyphersnake
feat: migrate to halo2-scroll (#301)
3fff676 
**Issue Link / Motivation**
Using one version of halo2curves will allow us to unfreeze #287,
halo2-kzg for #285 and fix smaller bugs

**Changes Overview**
- Migrating to halo2curves and reimporting it from the crate root
- Minor edits and fixes related to another version of halo2
@cyphersnake cyphersnake deleted the 285-poseidon-merkle-tree-benchmark branch September 30, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cyphersnake cyphersnake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(example): poseidon-based merkle-tree benchmark
1 participant
@cyphersnake