Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Predis vs Phpredis container definitions #383

Closed
LRotherfield opened this issue Jan 11, 2018 · 3 comments
Closed

Predis vs Phpredis container definitions #383

LRotherfield opened this issue Jan 11, 2018 · 3 comments
Assignees
@B-Galati
Labels
dx Developer eXperience enhancement Improves existing functionality
Milestone
3.0

Comments

@LRotherfield
Copy link

LRotherfield commented Jan 11, 2018 •
edited

Is there a reason that a Predis client gets the service definition name snc_redis.CLIENT_ALIAS but a Phpredis client gets the service definition name snc_redis.phpredis.CLIENT_ALIAS and an alias to snc_redis.CLIENT_ALIAS

I only noticed because we have a couple of instances (using the oro platform, part of the cache dumping) where services are requested by getDefinition method rather than findDefinition method and so, when using the snc_redis.CLIENT_ALIAS key, Predis clients don't throw an error because they have an actual definition but Phpredis client definitions cannot be found as getDefinition does not look for aliases.

Would be interested to hear your thoughts
@curry684
Copy link
Collaborator

curry684 commented Apr 6, 2018

Agreed, pretty weird. Fixing it would imply major BC break though so let's see if we can get this done in 3.0.

@curry684 curry684 added dx Developer eXperience enhancement Improves existing functionality labels Apr 6, 2018
@curry684 curry684 added this to the 3.0 milestone Apr 6, 2018
@B-Galati
Copy link
Collaborator

Should be fixed in 3.0.0-RC1.
Please let me know.

@B-Galati
Copy link
Collaborator

Not fixed I will clean this up before stable (#452 )

B-Galati added a commit to B-Galati/SncRedisBundle that referenced this issue Feb 21, 2019
@B-Galati
fix snc#383 - deprecates redis service alias in favor of 'snc_redis.{…
fced069 
…alias}_client'
@B-Galati B-Galati self-assigned this Feb 21, 2019
B-Galati added a commit to B-Galati/SncRedisBundle that referenced this issue Feb 21, 2019
@B-Galati
fix snc#383 - deprecates redis service alias in favor of 'snc_redis.{…
ac61000 
…alias}'
B-Galati added a commit to B-Galati/SncRedisBundle that referenced this issue Feb 21, 2019
@B-Galati
fix snc#383 - deprecates redis service alias in favor of 'snc_redis.{…
64002b4 
…alias}'
B-Galati added a commit to B-Galati/SncRedisBundle that referenced this issue Feb 21, 2019
@B-Galati
fix snc#383 - remove redis service alias in favor of 'snc_redis.{alias}'
02abf1a
B-Galati added a commit to B-Galati/SncRedisBundle that referenced this issue Feb 23, 2019
@B-Galati
fix snc#383 - remove redis service alias in favor of 'snc_redis.{alias}'
68498af
B-Galati added a commit to B-Galati/SncRedisBundle that referenced this issue Feb 23, 2019
@B-Galati
fix snc#383 - deprecates redis service alias in favor of 'snc_redis.{…
87b0394 
…alias}'
B-Galati added a commit to B-Galati/SncRedisBundle that referenced this issue Mar 14, 2019
@B-Galati
fix snc#383 - deprecates redis service alias in favor of 'snc_redis.{…
450a7f2 
…alias}'
B-Galati added a commit that referenced this issue Mar 26, 2019
@B-Galati
Merge pull request #501 from B-Galati/issue-383
50f4c23 
fix #383 - deprecates redis service alias in favor of 'snc_redis.{alias}'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@B-Galati B-Galati

Labels
dx Developer eXperience enhancement Improves existing functionality
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@LRotherfield @B-Galati @curry684