Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max list length parameter #123

Closed
wants to merge 5 commits into from
Closed

Add max list length parameter #123

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 22, 2014

Hi,

I propose to add a max list length for the monolog handler.
Because there is currently no way to limit the logs.

Ben.

@snc
Copy link
Owner

snc commented Feb 1, 2014

Please have a look at #122. I think that the handler provided by monolog should be used. Maybe we could provide a child class of this handler which then adds new features like your proposed one? What do you think?

@ghost
Copy link
Author

ghost commented Feb 1, 2014

I already thought about it, then decided to use your handler, because monolog's handler immediately writes to redis, there is no buffer.
Thinking about it now... it probably doesn't change anything...
Well, not 100% sure, that's why I didn't do it.

What do you think ?

@snc
Copy link
Owner

snc commented Mar 8, 2014

I'm not sure if it is possible to configure monolog to buffer the messages but I think you are right, should not make that much difference.

@Seldaek
Copy link
Collaborator

Seldaek commented Mar 29, 2018

Monolog's handler now has a $capSize arg so I think this can be closed. Note that you can also combine/wrap it with a BufferHandler if you wanna do writes at once but it won't change much IMO except for grouping entries perhaps.

@Seldaek Seldaek closed this Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants