Fix support for Heroku style REDIS_URL env variables #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B-Galati
force-pushed
the
fix-410
branch
2 times, most recently
from
3fc44dc
to
f3f1bc4
Compare
|
Can you rebase on current master? It should fix the tests. |
B-Galati
changed the title
Co-authored-by: Klaus Großmann <kgm@petsdeli.de> Co-authored-by: Benoit Galati <benoit.galati@gmail.com>
B-Galati
changed the title
|
@curry684 Done and also make some changes, thanks ;-) It looks good overall but I am not sure if it's breaking something else or not. |
curry684
approved these changes
Apr 17, 2018
|
I think tests should catch that, and it's going into master not right into stable. |
|
Thanks. What should I do to fix 2.1? |
|
Good job @B-Galati ! 🏅 👌 |
|
Thanks @B-Galati 😃 Merged it into master, not bothering with 2.1 anymore as it's pretty invasive and I'm trying to keep that one stable after recent issues, also the behavior has been broken for months already without many complaints. |
|
Hmm my bad, I thought it was broken before 2.1.0 already. I'll see if I can merge it back into 2.1. |
curry684
pushed a commit
that referenced
this pull request
Apr 25, 2018
* Fix support for Heroku style REDIS_URL env variables Co-authored-by: Klaus Großmann <kgm@petsdeli.de> Co-authored-by: Benoit Galati <benoit.galati@gmail.com> * Add one simple test (cherry picked from commit 355251c)
|
See #356, we're reopening up an old issue here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically re-add what was done in #353
fixes #410
I also think that redis profile should not be resolved/interpolated in cache.