Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally enable lazy loading for phpredis #487

Merged
merged 1 commit into from
Jan 17, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion DependencyInjection/SncRedisExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,17 @@ protected function loadPhpredisClient(array $client, ContainerBuilder $container
$phpredisDef->addArgument($client['alias']);
$phpredisDef->addTag('snc_redis.client', array('alias' => $client['alias']));
$phpredisDef->setPublic(false);
$phpredisDef->setLazy(true);

// Older version of phpredis extension do not support lazy loading
$minimumVersionForLazyLoading = '4.1.1';
$supportsLazyServices = version_compare($phpRedisVersion, $minimumVersionForLazyLoading, '>=');
$phpredisDef->setLazy($supportsLazyServices);
if (!$supportsLazyServices) {
@trigger_error(
sprintf('Lazy loading Redis is not supported on PhpRedis %s. Please update to PhpRedis %s or higher.', $phpRedisVersion, $minimumVersionForLazyLoading),
E_USER_WARNING
);
}

$container->setDefinition($phpredisId, $phpredisDef);
$container->setAlias(sprintf('snc_redis.%s', $client['alias']), new Alias($phpredisId, true));
Expand Down