fix #249 - fix session handler lock key prefix

[B-Galati]

No description provided.

[Seldaek]

Looks fine to me but it's just a code cleanup, I don't see how it fixes that issue.

[B-Galati]

@Seldaek Me neither, I think I am misunderstanding something :D

I'll check it out again tomorrow.

Thx!

[B-Galati]

@Seldaek @curry684 I think I don't get what the issue is or there is no issue left.

This is what I have in logs when I logged in. Does it look ok to you?

[B-Galati]

Here is the full log trace :

Feb 21 11:18:14 |INFO | REQUES Matched route "app_login". method="POST" request_uri="http://localhost:8002/login" route="app_login" route_parameters={"_controller":"App\\Controller\\SecurityController::login","_route":"app_login"}
Feb 21 11:18:14 |DEBUG| SNC_RE Executing command "SET benoitl93kq4j8a80qf22rul84orl432.lock 5c6e7ae6795bc NX PX 30001"
Feb 21 11:18:14 |DEBUG| SNC_RE Executing command "GET benoitl93kq4j8a80qf22rul84orl432"
Feb 21 11:18:14 |DEBUG| SNC_RE Executing command "DEL benoitl93kq4j8a80qf22rul84orl432"
Feb 21 11:18:14 |DEBUG| SNC_RE Executing command "SET benoith1fb387n0ib4lkvhqfl85s3k3s.lock 5c6e7ae679b09 NX PX 30001"
Feb 21 11:18:14 |DEBUG| SNC_RE Executing command "GET benoith1fb387n0ib4lkvhqfl85s3k3s"
Feb 21 11:18:14 |INFO | SECURI User has been authenticated successfully. username="benoit"
Feb 21 11:18:14 |DEBUG| SECURI Stored the security token in the session. key="_security_main"
Feb 21 11:18:14 |DEBUG| SNC_RE Executing command "SETEX benoitmvbeq4p1oga4hmnd6bujmpkqos 1200 _sf2_attributes|a:2:{s:18:"_csrf/authenticate";s:43:"D5RH7v0OUUjvBbdOJGmjFa0vejTPyHLP_O88bp6Rats";s:14:"_security_main";s:845:"C:74:"Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken":757:{a:3:{i:0;N;i:1;s:4:"main";i:2;a:4:{i:0;O:41:"Symfony\Component\Security\Core\User\User":7:{s:51:"Symfony\Component\Security\Core\User\Userusername";s:6:"benoit";s:51:"Symfony\Component\Security\Core\User\Userpassword";s:6:"benoit";s:50:"Symfony\Component\Security\Core\User\Userenabled";b:1;s:60:"Symfony\Component\Security\Core\User\UseraccountNonExpired";b:1;s:64:"Symfony\Component\Security\Core\User\UsercredentialsNonExpired";b:1;s:59:"Symfony\Component\Security\Core\User\UseraccountNonLocked";b:1;s:48:"Symfony\Component\Security\Core\User\Userroles";a:1:{i:0;s:9:"ROLE_USER";}}i:1;b:1;i:2;a:1:{i:0;O:41:"Symfony\Component\Security\Core\Role\Role":1:{s:47:"Symfony\Component\Security\Core\Role\Rolerole";s:9:"ROLE_USER";}}i:3;a:0:{}}}}";}_sf2_meta|a:3:{s:1:"u";i:1550744294;s:1:"c";i:1550744294;s:1:"l";s:1:"0";}"
Feb 21 11:18:14 |INFO | REQUES Matched route "default". method="GET" request_uri="http://localhost:8002/" route="default" route_parameters={"_controller":"App\\Controller\\DefaultController::index","_route":"default"}
Feb 21 11:18:14 |DEBUG| SNC_RE Executing command "SET benoitmvbeq4p1oga4hmnd6bujmpkqos.lock 5c6e7ae688f36 NX PX 30001"
Feb 21 11:18:14 |DEBUG| SNC_RE Executing command "GET benoitmvbeq4p1oga4hmnd6bujmpkqos"
Feb 21 11:18:14 |DEBUG| SECURI Read existing security token from the session. key="_security_main" token_class="Symfony\\Component\\Security\\Core\\Authentication\\Token\\UsernamePasswordToken"
Feb 21 11:18:14 |DEBUG| SECURI User was reloaded from a user provider. provider="Symfony\\Component\\Security\\Core\\User\\InMemoryUserProvider" username="benoit"
Feb 21 11:18:14 |DEBUG| SECURI Stored the security token in the session. key="_security_main"
Feb 21 11:18:14 |DEBUG| SNC_RE Executing command "EXPIRE benoitmvbeq4p1oga4hmnd6bujmpkqos 1200"

[B-Galati]

@curry684 @Seldaek Double check this morning. Everything looks good to me before this PR and after this PR.
Maybe I am missing something.

[curry684]

The issue is 3 years old, and @Seldaek already rebuilt the session handler for 3. I think it was sort of fixed 'along the way' and is only an issue in 2.x, which makes it doubtful if we want to bother fixing it.

[B-Galati]

So let's merge this one for the little clean-up and say it is fixed? Is it ok for you @curry684?

[curry684]

^^ 👍 😄