Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConnectionWrapper with aggregated connections #675

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Fix ConnectionWrapper with aggregated connections #675

merged 2 commits into from
Oct 28, 2022

Conversation

specdrum-agc
Copy link
Contributor

@ostrolucky
Copy link
Collaborator

Sorry, I have tested this, but it doesn't solve described issue. Try this configuration

snc_redis:
        predis:
            type: predis
            alias: predis
            dsn:
                - redis://127.0.0.1:9999
                - redis://127.0.0.1:6379
            options:
                cluster: redis

then execute any command via bin/console redis:query --client=predis. With this patch, you will still get

In ConnectionWrapper.php line 169:

  Connection refused [tcp://127.0.0.1:9999]

Once the config is switched from predis to phpredis, it works correclty then and it fails over to next redis node.

@specdrum-agc
Copy link
Contributor Author

specdrum-agc commented Oct 28, 2022

My bad, I passed wrong object to the exception.

@ostrolucky
Copy link
Collaborator

Great, this one is working, thx. I'll release now

@ostrolucky ostrolucky merged commit 49cccfc into snc:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregate connections are not being removed in combination with own connection class
2 participants