Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #298

Merged
merged 10 commits into from Apr 20, 2021
Merged

Update docs #298

merged 10 commits into from Apr 20, 2021

Conversation

kboone
Copy link
Member

@kboone kboone commented Apr 19, 2021

This contains a big update to the Spectrum docs, and bunch of small fixes to the rest of the docs for things that have broken over time.

docs/spectrum.rst Outdated Show resolved Hide resolved
@benjaminrose
Copy link
Member

Thanks @kboone! I'm appreciative that someone found time to work on the documentation.

Two related questions: 1) Once this is merged, should we start a release with SALT3 and these changes? 2) Is there something we can do to ensure future model additions don't break the "List of Built-in Sources"?

@kboone
Copy link
Member Author

kboone commented Apr 20, 2021

To avoid this in the future, we should add a test to make sure that the docs compile without errors. There were errors in that build, but they weren't flagged when we were merging PRs.

Yes, I'll put out a new release when this is merged.

@kboone kboone merged commit 157c3a6 into sncosmo:master Apr 20, 2021
@kboone kboone deleted the update_docs branch April 20, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants