fixed bugs in the implementation of the SALT3 error model #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbarbary
reviewed
May 22, 2021
kbarbary
reviewed
Sep 2, 2021
|
Anything else to do here? This seems important to fix! |
Merged
|
This all looks good to me, and I fixed the last style issue that @kbarbary brought up in #313 since I can't edit this PR. I'm going to go ahead and merge it. Thanks @djones1040! |
kboone
added a commit
that referenced
this pull request
Sep 8, 2021
fixed bugs in the implementation of the SALT3 error model
|
hey guys, thank you so much - was just hiking and totally offline for the last three weeks, really appreciate you closing this out and please lmk if there's anything else I can do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry guys, accidentally had some bugs in SALT3Source _bandflux_rvar_single that was resulting in anomalously high chi^2 values from SALT3. These should all be fixed now.